Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): share body parsing and external ref logic with core #160

Merged
merged 12 commits into from
Jun 17, 2024

Conversation

jamesdabbs
Copy link
Member

@jamesdabbs jamesdabbs commented Jun 15, 2024

This is the ~first of several changes we'll want to make to push logic that is currently in the viewer or compiler down into the core, so that we can share it between those and the VSCode extension and keep them operating consistently. The goal with this one is getting the parsing toolchain working at all, and at least rendering external links. Internal links have a few complications that can be addressed as a follow-up.

Screenshot 2024-06-15 at 9 29 05 AM

Note that the dependency shuffling here required(?) us to move from esbuild to webpack, to get better support for shimming the unified ecosystem's node:path dependencies &c.

Review Notes

This PR is (essentially) branched off of #155 and (inessentially) off of #158. The main work here is 3ffa14a, which may be easier to review in isolation. If it'd help, we can pull out some of the other commits.

Testing Notes

This is currently published as a prerelease version (0.1.18) which you can opt into to test –

Screenshot 2024-06-15 at 9 19 42 AM

(See also the Testing Notes in #158)

@jamesdabbs jamesdabbs self-assigned this Jun 15, 2024
@jamesdabbs jamesdabbs changed the base branch from main to jcd/vscode June 15, 2024 15:55
Copy link

cloudflare-workers-and-pages bot commented Jun 15, 2024

Deploying topology with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7370c31
Status: ✅  Deploy successful!
Preview URL: https://3d123fdd.topology.pages.dev
Branch Preview URL: https://jcd-vscode-parser.topology.pages.dev

View logs

@jamesdabbs jamesdabbs changed the title Jcd/vscode parser feat(vscode): share body parsing and external ref logic with core Jun 15, 2024
and update the VSCode extension to use the body parsing logic in
hover previews. Still a few polishing items to do here:

- expand internal references to linked names
- fix katex styling oddities

but this is a reasonable enough start to at least publish as a
prerelease version.
@jamesdabbs jamesdabbs marked this pull request as ready for review June 15, 2024 16:26
@StevenClontz
Copy link
Member

I gave it a spot test just now and didn't run into anything broken.

@jamesdabbs jamesdabbs changed the base branch from jcd/vscode to main June 17, 2024 00:27
@jamesdabbs jamesdabbs merged commit fe47feb into main Jun 17, 2024
3 checks passed
@jamesdabbs jamesdabbs deleted the jcd/vscode-parser branch June 17, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants