Improve API calls for Top Clients and Forward Destinations #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DL6ER
changed the title
DL6ER
changed the title
DL6ER
added a commit
to pi-hole/pi-hole
that referenced
this pull request
Dec 15, 2016
6 tasks
|
Will this add lots of extra queries to the log? |
|
It will add (max) 10+2 PTR requests each time. However, we will exclude |
… to check if the line includes "query" since we only collect "query" lines now
DL6ER
changed the title
Conflicts: data.php
|
Hmmm, something in this PR set my I thought that was fixed in devel? |
|
Approved |
Yes, I guess the branch was not up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
trueUpstream DNS servers:
API_GET_UPSTREAM_DNS_HOSTNAMEClients:
API_GET_CLIENT_HOSTNAMEhttp://pi.hole/admin/api.php?getForwardDestinationsdevel: 5.8sthis PR: 3.3s
http://pi.hole/admin/api.php?getQuerySourcesdevel: 15.6sthis PR: 4.6s
@pi-hole/dashboard