Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Log "Unknown" entry #102

Closed
3 tasks done
DL6ER opened this issue Jun 23, 2017 · 5 comments
Closed
3 tasks done

Query Log "Unknown" entry #102

DL6ER opened this issue Jun 23, 2017 · 5 comments
Labels

Comments

@DL6ER
Copy link
Member

DL6ER commented Jun 23, 2017

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

  • I have read and understood the contributors guide.
  • The issue I am reporting can be replicated
  • The issue I am reporting isn't a duplicate

How familiar are you with the codebase?:

10


[BUG | ISSUE] Expected Behaviour:

git-lfs.github.com query log entry listed as OK

[BUG | ISSUE] Actual Behaviour:

git-lfs.github.com query log entry listed as Unknown but this does not seem to be reproducible

screenshot at 2017-06-23 17-16-58

Interestingly, the Unknown status is gone after restarting FTL, so I assume FTL wasn't able to find it in pihole.log due to a yet unknown reason.

screenshot at 2017-06-23 17-20-55

pihole.log excerpt

Jun 23 17:04:42 dnsmasq[20193]: query[A] git-lfs.github.com from 127.0.0.1
Jun 23 17:04:42 dnsmasq[20193]: forwarded git-lfs.github.com to 2001:1608:10:25::1c04:b12f
Jun 23 17:04:42 dnsmasq[20193]: reply git-lfs.github.com is <CNAME>
Jun 23 17:04:42 dnsmasq[20193]: reply github.map.fastly.net is 151.101.112.133
@DL6ER DL6ER added the Bug label Jun 23, 2017
@DL6ER
Copy link
Member Author

DL6ER commented Jun 30, 2017

Possible solution: Wait longer than 100 milliseconds in parser.c#L400

@tording
Copy link

tording commented Jul 16, 2017

I am having this same issue. Requests showing up as unknown in the query log but the requests are actually working, just showing unknown. Where is this file that I change the wait to longer than 100 milliseconds?

@AzureMarker
Copy link
Contributor

@DL6ER
Copy link
Member Author

DL6ER commented Jul 18, 2017

@tording Does this go away if you restart pihole-FTL? The line I posted in my comment above is the place where you would have to change it. However, you'd have to compile FTL locally. I'm still looking into a more elegant solution.

@PromoFaux PromoFaux assigned PromoFaux and unassigned PromoFaux Aug 24, 2017
@DL6ER
Copy link
Member Author

DL6ER commented Sep 3, 2017

Unfortunately, this seems to be an expected issue on systems that are either very slow or under heavy load. It is caused by dnsmasq's async logging. I found no really elegant solution to this that would not affect the performance of FTL in a notable way (as we would have to wait on dnsmasq's output that is delayed in these cases).

Restarting FTL will always resolve this problem when re-parsing the log file.

Feel free to re-open once you find an elegant solution to this issue.

@DL6ER DL6ER closed this as completed Sep 3, 2017
DL6ER pushed a commit that referenced this issue Oct 14, 2019
Simplify the recent blocked endpoint to use FtlQuery::is_blocked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants