Fix negative "others" in Upstream Servers pie chart #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
changed the title
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/wrong-percent-calculation-in-pie-chart-v2/53599/13 |
yubiuser
reviewed
Feb 18, 2022
yubiuser
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Has been confirmed fixing negative others here
https://discourse.pi-hole.net/t/wrong-percent-calculation-in-pie-chart-v2/53599/9?u=yubiuser
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
This was referenced Apr 20, 2022
1 task
1 task
This was referenced Apr 24, 2022
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Fix the reference using in the
Upstream Serverspie chart. This chart shows how many queries are being sent to the respective destinations. We recently introduced a special category "other" that summarizes everything which does not fall into one of the available categories (like local SERVFAIL). The bug is that we have recently seen reports for negative other shares. This is caused by a wrong reference being used. As Pi-hole is periodically sending one and the same query to multiple upstream servers to probe which one is the fastest. This may cause five queries for only one "real" query. You see where this is leading...The bugfix simply changes the reference frame from "how many queries we know" to "how many queries we sent". We leave a comment about this in the code for future reference.