Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we also change ownership of the WAL database files #1970

Merged
merged 1 commit into from
May 18, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 18, 2024

What does this implement/fix?

If FTL is being invoked in an unusual way, it can happen that the database is created as root and later re-owned to a low-privilege user. Since the default database mode is now WAL, we have additional -shm and -wal files which need to be re-owned as well or the database becomes read-only.

This permission issue "auto-fixes" on the next FTL restart and everything will be fine thereafter. Nonetheless, this PR ensures the permissions are already correct during the initial start and not only after the first restart.


Related issue or feature (if applicable): See linked Discourse thread below.

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/usage-of-dnsmasqs-user-option-does-not-chown-db-shm-and-db-wal-files-on-first-launch/70244/3

@DL6ER
Copy link
Member Author

DL6ER commented May 18, 2024

Confirmed working by OP on Discourse

@DL6ER DL6ER merged commit 5243083 into development-v6 May 18, 2024
15 checks passed
@DL6ER DL6ER deleted the fix/wal-ownership branch May 18, 2024 17:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants