Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IGNORE_LOCALHOST config option #254

Merged
merged 3 commits into from
Apr 14, 2018
Merged

Add IGNORE_LOCALHOST config option #254

merged 3 commits into from
Apr 14, 2018

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Apr 11, 2018

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This solves pi-hole/web#719

Note that queries from localhost will not just be hidden but completely ignored. This will impact the generated statistics and might hide information!

This template was created based on the work of udemy-dl.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Copy link
Contributor

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, will test soon

@DL6ER DL6ER merged commit 2e24b81 into FTLDNS Apr 14, 2018
@DL6ER DL6ER deleted the FTLDNS-IGNORE_LOCALHOST branch April 14, 2018 09:44
@AzureMarker
Copy link
Contributor

Tested, works

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/option-to-ignore-hosts-from-appearing-in-the-query-log/6319/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants