-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple list format for gravity.list and black.list #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds up list importing by about 2x Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…s thanks to the new lists format Signed-off-by: DL6ER <dl6er@dl6er.de>
…ld reply with IPv4/IPv6 addresses (need 2 cache slots per domain) or with NXDOMAIN (need 1 cache slot per domain) Signed-off-by: DL6ER <dl6er@dl6er.de>
… FTL hook Signed-off-by: DL6ER <dl6er@dl6er.de>
… still in HOSTS format, we accept this, print a message that the user should run pihole -g and still import the lists as regular hosts lists. Note that BLOCKINGMODE=NXDOMAIN won't work with HOSTS lists import. Signed-off-by: DL6ER <dl6er@dl6er.de>
5 tasks
…quire a valid IP address for NXDOMAIN blocking... Signed-off-by: DL6ER <dl6er@dl6er.de>
8 tasks
PromoFaux
approved these changes
Apr 23, 2018
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/nxdomain-and-null-blocking-with-ftldns/9634/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
development
branch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
This PR introduces a few improvements for huge block lists:
NXDOMAIN
information so that exact blocking withNXDOMAIN
replies becomes possible.This PR has the advantage of removing unnecessary overhead introduced by config or HOSTS notation as this does not add any additional information here.
If we agree on this, I will add exact
NXDOMAIN
blocking in a follow-up PR.Note that this PR depends on you having checked out
FTLDNS-gravity-simplelists
and rangravity
at least once on this branch. Further details here: pi-hole/pi-hole#2140This template was created based on the work of
udemy-dl
.