Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use database table for domain auditlog #608

Merged
merged 12 commits into from
Jul 11, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 5, 2019

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This PR implements the changes due to pi-hole/pi-hole#2832 in pihole-FTL. To ensure low response times, we generalize the in_whitelist(domain) routine and use a similar technique for in_auditlist(domain).

This PR build on #605 and should not be reviewed before its parent PR has been merged to development.

DL6ER added 7 commits July 5, 2019 16:14
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…nfig{.c/.h}

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…bug flag is set.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.0 milestone Jul 5, 2019
DL6ER added 2 commits July 6, 2019 09:34
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER changed the title New/use audit database table Use database table for domain auditlog Jul 6, 2019
@DL6ER DL6ER changed the base branch from development to new/modularize_headers July 6, 2019 15:20
@DL6ER
Copy link
Member Author

DL6ER commented Jul 6, 2019

Changed base so this PR can now be reviewed and merged towards the refactor branch. In case the refactor branch is merged first, this PR can be rebased to development without any issues.

@DL6ER DL6ER marked this pull request as ready for review July 6, 2019 15:22
Copy link
Contributor

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending merge of pi-hole/pi-hole#2832

@AzureMarker AzureMarker changed the base branch from new/modularize_headers to development July 9, 2019 03:10
@AzureMarker AzureMarker merged commit 7671fe9 into development Jul 11, 2019
@AzureMarker AzureMarker deleted the new/use_audit_database_table branch July 11, 2019 02:57
@DL6ER DL6ER mentioned this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants