Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reopen gravity database when not available #699

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 22, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Access to the gravity database is essential for correct working of pihole-FTL. Try to reopen the gravity database when it was not available due to an existing lock.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.0 milestone Feb 22, 2020
… This may help on slow devices where updating the database is not yet finished when FTL is already trying to re-read to database tables.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER marked this pull request as ready for review February 24, 2020 09:22
@DL6ER
Copy link
Member Author

DL6ER commented Feb 24, 2020

User confirmed this fixes a bug for them: pi-hole/web#1139 (comment)

@DL6ER DL6ER merged commit 71e8498 into release/v5.0 Feb 25, 2020
@DL6ER DL6ER deleted the fix/sqlite_crash branch February 25, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants