Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.3] Bug in query log page #52

Closed
DonLexos opened this issue Mar 2, 2016 · 12 comments
Closed

[1.1.3] Bug in query log page #52

DonLexos opened this issue Mar 2, 2016 · 12 comments

Comments

@DonLexos
Copy link

DonLexos commented Mar 2, 2016

Expected Behaviour:

Would expect to see the proper type/domain/client

Actual Behaviour:

I see type: q[32178] domain query[A] and client is from

The frontpage does work. Seems something shifted on the query log page.

Steps to reproduce this issue:

Running Pi-hole Version v2.5.3 Web Interface Version v1.1.3. Tried updateDashboard.sh but that did not fix it, 1.1.3 is really the latest.

@AzureMarker
Copy link
Contributor

This should be fixed in the latest devel branch. (Just fixed yesterday)

@AzureMarker
Copy link
Contributor

It seems that something moved the log entries right one. We should really change from hardcoded indexes though.

@DonLexos
Copy link
Author

DonLexos commented Mar 2, 2016

Oh ok I checked the wiki and it's not in there I believe.

@DonLexos
Copy link
Author

DonLexos commented Mar 2, 2016

But good to know, no clue how to label things (or even know if I am allowed to) but otherwise someone might be able to label in-next-release or something.

@AzureMarker
Copy link
Contributor

Ya, with how fast everything is going, the changelog gets behind sometimes.

@DonLexos
Copy link
Author

DonLexos commented Mar 2, 2016

Found it! No clue how I can link directly to a commit but it's this one #ddb2aa3

@AzureMarker
Copy link
Contributor

I don't think you need the #

@PromoFaux
Copy link
Member

Ah, OK, I just posted a picture in slack with this same thing. :) had an email question about it too. Any chance of pushing the fix to master? Might confuse some users. Otherwise.

Strip the password stuff out of devel first though.

@DonLexos
Copy link
Author

DonLexos commented Mar 2, 2016

I made the link manually since I was unable to find out how. If I do a # I get link options to issues, no clue how you link to commits easily. it's in this pull request #51

@AzureMarker
Copy link
Contributor

I'll work on sending to master.

@AzureMarker
Copy link
Contributor

Released

@DonLexos
Copy link
Author

DonLexos commented Mar 3, 2016

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants