Add SEO Description / SEO Title / SEO keywords

[Marc-pi]

to suppress GWT warnings => had this in module configs

[voltan]

I have same idea , its added on git, please test

[Marc-pi]

i vote for not having SEO options for finish page (post submit page), and add no-follow/no-index to this page instead
i guess i need to install latest code of Pi, but i need perhaps your PR, no?

[voltan]

This version work whit last version of PI

But about no-follow/no-index , at this moment I don't want add it , I think about remove finish page and add ajax method for show finish text. if this part is OK, please close this issues , I need more time for think about this.

I will back to it after finish other modules

[Marc-pi]

In case Title contains a latin apostrophe (ex: J'aime) - we have a lot in french and italian - HTML equivallent code is displayed in Browser, must be interpreted (we can keep html code in keywords, i think its ok)
Other wise :

• Upper/Lower cases in Description and Title are ok, comma, etc.also
• expression keywords are ok in keywords

[voltan]

I use meta filters from core , if any chnage needed , we need update this filters

[Marc-pi]

works well with Page module and same text for SEO Title, KO on contact
both use same filters, strange
output rendering has an issue on contact

[voltan]

For SEO head meta on page module please check my last chnages and bug fix on page module from here : https://github.com/voltan/pi

If you check codes , I don't use any extar method on meta headers and just set them on core view plugins

[Marc-pi]

so the plugin has a regression, worked well before
for your test, you can put such a latin phrase, that must stick in Title like it is key in the field
J'aime les fraises : c'est bon, on en prend à l'hôtel, et c'est GRAND

[Marc-pi]

r4451, bug confirmed on contact module, ok on page module

[voltan]

I remove _escape function , I think at this moment its fix , But its not true method , _escape remove all bad codes ( for example XSS ) from texts before render for user. we need back it on this module and we use it on all other modules , I think this function need fix

[Marc-pi]

How it is managed on page module, where it works correctly ?

[voltan]

On page we don't use it for met headers (I think should added ) , but please check other modules , we use it on all templates and need use it on meta too

[Marc-pi]

yep, data from inside should be filtered correctly also, to prevent from tainted data and manage security as a whole (no breach reinforce the global security)
@taiwen @voltan seems the filters have to be tweaked a little more
pi-engine/pi#1290

Remind

• On SEO Title and SEO Description , such a phrase must be correctly managed , , / é è à â ô û î... / uppercase / '/ | must be accepted

J'aime les fraises : c'est bon, on en prend à l'hôtel l'été, et c'est GRAND

• On SEO Keywords, expression keywords must be accepted (blank, -,

pique-nique , tour eiffel

[voltan]

I think at this moment we can close it , if any change needed can be add on core filters