Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given keyword in dutch overlaps text #219

Merged
merged 2 commits into from
Oct 6, 2015
Merged

Given keyword in dutch overlaps text #219

merged 2 commits into from
Oct 6, 2015

Conversation

maartenvandiemen
Copy link

We're using SpecFlow configured for the Dutch language. When generating documentation for the Dynamic HTML format the Given (Gegeven in Dutch) overlaps the text.
image

I've changed the width of the keyword class to 60px. This results in no overlapping text in Dutch.
image

The English documentation will look like this with this change:
image

Old (current)
image

@dirkrombauts
Copy link
Member

Hi,

Thanks for your time and effort! There was a similar issue some time ago in the static html version (#209 - interestingly also for Dutch).

Back then I decided to remove the right-alignment of the keywords altogether: it looks good in English, but as soon as a more verbose language comes along it breaks down. Today we notice a problem in Dutch, and maybe tomorrow another language with even longer keywords comes along ...

So would you mind adapting your pull request so that the right-alignment is removed altogether? Thank you very much!

@maartenvandiemen
Copy link
Author

Removed right-alignment. Example of Dutch language with the change:
image

Example of English with the change
image

Does this mean we undo #195?

dirkrombauts added a commit that referenced this pull request Oct 6, 2015
Given keyword in dutch overlaps text
@dirkrombauts dirkrombauts merged commit 8ef73e7 into picklesdoc:master Oct 6, 2015
@dirkrombauts
Copy link
Member

Hi,

Thanks for your help! Yes, it means we undo #195. That feature sounded good at the time but I didn't think it through completely.

@dirkrombauts
Copy link
Member

I released a new version with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants