Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when no Description is provided #314

Conversation

danielpullwitt
Copy link

Having a feature without a description crashes documentation generation to word and excel format.

@dirkrombauts
Copy link
Member

Thank you for your contribution! I try to follow a strict test-first policy (or at least accompanied-by-tests ;-) ), so could you please add a unit test? https://github.com/picklesdoc/pickles/blob/develop/src/Pickles/Pickles.Test/ObjectModel/MapperTestsForFeature.cs would be a good place.

@danielpullwitt
Copy link
Author

No problem; one unit test added, in style similiar to the one existing for the scenario mapper.

@dirkrombauts dirkrombauts merged commit 04a98db into picklesdoc:develop Apr 6, 2016
@dirkrombauts
Copy link
Member

Thanks again! I hope to release a new version early next week.

@danielpullwitt danielpullwitt deleted the feature/InitializeOnEmptyDescriptions branch April 6, 2016 13:31
@dirkrombauts dirkrombauts changed the title Ensure description of feature is never null Prevent crash when no Description is provided Apr 12, 2016
@dirkrombauts
Copy link
Member

Released in version 2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants