SpecFlow conformant name mapping in nUnit test result provider #315
Conversation
|
Thanks for this contribution as well, and thanks for providing tests. I will review the pull request in detail tomorrow (European time). |
|
I agree in principle with your contribution. Just a few details with regard to code style and spelling - I will add them as comments to the changed files. |
| @@ -44,5 +48,8 @@ public Regex Build(ScenarioOutline scenarioOutline, string[] row) | |||
|
|
|||
| return new Regex(stringBuilder.ToString()); | |||
| } | |||
|
|
|||
| private static readonly Regex punctuationCharactersRegex = new Regex(@"[\n\.-]+", RegexOptions.Compiled); | |||
There was a problem hiding this comment.
I usually follow the StyleCop rules that instruct us to add fields before methods.
There was a problem hiding this comment.
Also, because the fields are static, I prefer the name to begin with an uppercase letter.
…SpecFlows name generation logic wrt. to special characters
danielpullwitt
force-pushed
the
feature/NunitNameMapping
branch
from
80f55aa
to
64e8e88
Compare
|
I have applied your comments to our changes under the assumption you meant replacing tabs by spaces (at least this would be conforming to the project)? |
|
Lol yes you are correct I meant replacing the tabs with spaces. Thank you for thinking with me :-) |
|
Thanks again for your contributions, they are much appreciated! |
dirkrombauts
changed the title
|
Released in version 2.6.0 |
The name mapping of the nunit signature builder fails on presence of special characters (e.g. comma, hyphen).
Added the same regular expression translation steps as used by the SpecFlow code generator along with a unit test for the matching.