Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null reference error when running with MsTest trx results file #356

Closed
surekhadhal opened this issue Jul 7, 2016 · 9 comments
Closed

Null reference error when running with MsTest trx results file #356

surekhadhal opened this issue Jul 7, 2016 · 9 comments

Comments

@surekhadhal
Copy link

Fixed by adding a null check for input parameter "scenario" in method ExecutionIdElement(this XElement scenario) in MsTestElementExtensions.cs file.

@dirkrombauts
Copy link
Member

Thank you for spotting and reporting this one. I will add some more information about how to fix this issue, and then put it "up for grabs".

@dirkrombauts
Copy link
Member

In order to do this in a test-driven way, the implementer(s) should create a test class MsTestElementExtensionsTests in $/Pickles.TestFrameworks.UnitTests/MsTest, and a test method that calls the method MsTestElementExtensionsTests.ExecutionIdElement with a null argument. That test will fail.

Then the actual method can be changed to make the test pass.

@am071092
Copy link

am071092 commented Sep 4, 2016

What are the steps to reproduce the defect? I am using the UI to upload the "results-example-mstest.trx" file but I'm not getting the null pointer exception?

@dirkrombauts
Copy link
Member

The UI will catch that error, and should display it in the trace grid at the bottom of the screen.

@ankurmalhotra are you trying to solve this issue?

@am071092
Copy link

am071092 commented Sep 7, 2016

Yes would like to try to solve it if no one else is looking at it. Thanks

@dirkrombauts
Copy link
Member

Great! I wrote some instructions earlier in this thread. Do you need additional information?

@thopark
Copy link

thopark commented Sep 28, 2016

@ankurmalhotra you still work on this? Maybe it's the same problem as in #375

@am071092
Copy link

am071092 commented Sep 28, 2016

i am working on it. But if you've already got a fix, then go for it

@dirkrombauts dirkrombauts mentioned this issue Nov 29, 2016
@dirkrombauts dirkrombauts changed the title Null reference error when running with MsTest trx results file. Null reference error when running with MsTest trx results file Dec 5, 2016
@dirkrombauts
Copy link
Member

Released in version 2.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants