AsyncReadDecompressor reads Ok(0) before EOF is reached

[jean-airoldie]

Basically if the read / write buffer is small enough (less than 54 bytes), AsyncReadCompressor::poll_read returns Poll::Ready(Ok(0)), which is the sentinel for EOF, even though we haven't actually reached end of file.

Here is the example. It uses my async_std branch because it makes the code simpler, but its also an issue on master.

[picoHz]

Close by a318259

[jean-airoldie]

This is not fixed. I'll open a PR later today.

[jean-airoldie]

I found this crate that handles the encoding & decoding. I'm wondering whether submitting a patch would be simpler.

[picoHz]

@jean-airoldie Is it related to this issue?

[jean-airoldie]

I mean indirectly. We could base the code on their generic state machine to correctly implement the async encoding & decoding. But I'm wondering of the benefits this might have over submitting a patch to add lz4 support.

[picoHz]

You mean move async feature from this crate to async-compression?
That sounds nice because we can remove all the dependencies.

One concern is the complexity of API. Though this crate has a lot of LZ4F options, the encoder interface of async-compression seems quite simple.

[picoHz]

Merged into #12