WKWebView: File upload causing uncaught exception if filename contains invalid URL characters

[lubos]

When viewing following HTML code using WKWebView

<input type="file">

And user selects a file which contains space character, the application will crash with NSInvalidArgumentException.

I think the issue is with RunOpenPanel function

Eto/src/Eto.Mac/Forms/Controls/WKWebViewHandler.cs

Lines 188 to 199 in 32703b9

	public override void RunOpenPanel(wk.WKWebView webView, wk.WKOpenPanelParameters parameters, wk.WKFrameInfo frame, Action<NSUrl[]> completionHandler)
	{
	var openDlg = new OpenFileDialog();
	if (openDlg.ShowDialog(Handler.Widget.ParentWindow) == DialogResult.Ok)
	{
	completionHandler(openDlg.Filenames.Select(r => new NSUrl(r)).ToArray());
	}
	else
	{
	completionHandler(null);
	}
	}

Before passing r variable to new NSUrl(r) we need to make sure r is URL encoded.

Or we should use fileURL function which returns NSUrl.