Fix an event handler leak in Binding.RemovePropertyEvent
#2644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the handler in
RemovePropertyEvent
doesn't work, as theTarget
of the handler is not thePropertyNotifyHelper
instance; it is the object that the handler is bound to.Instead, find the correct handler to remove by checking all invocations of the
PropertyChanged
event of the bound object, and comparing the internal handler of the invocation with the method's argument.Also, add unit tests to verify the correct behavior.
fixes #2446