Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an event handler leak in Binding.RemovePropertyEvent #2644

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Commits on Apr 16, 2024

  1. Fix an event handler leak in Binding.RemovePropertyEvent

    Removing the handler in `RemovePropertyEvent` doesn't work, as the
    `Target` of the handler is not the `PropertyNotifyHelper` instance; it
    is the object that the handler is bound to.
    
    Instead, find the correct handler to remove by checking all invocations
    of the `PropertyChanged` event of the bound object, and comparing the
    internal handler of the invocation with the method's argument.
    
    Also, add unit tests to verify the correct behavior.
    joerih committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    19baf47 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update so it works to remove a single event vs. only one when hooked …

    …to the same delegate.
    cwensley committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f9b4a85 View commit details
    Browse the repository at this point in the history