Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode! #1269

Merged
merged 7 commits into from
May 18, 2023
Merged

Add dark mode! #1269

merged 7 commits into from
May 18, 2023

Conversation

make-42
Copy link
Contributor

@make-42 make-42 commented May 8, 2023

No description provided.

This was referenced May 8, 2023
Copy link
Member

@vktr vktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! There are a few things I'd like to change, the biggest is the static Theming class which I think is mostly unnecessary and we can probably get by with a simple helper function on the configuration class.

Also indentation, it should be 4 spaces in all source files.

res/dbmigrations/20220508103321_insert_theme_id.sql Outdated Show resolved Hide resolved
src/picotorrent/application.cpp Outdated Show resolved Hide resolved
src/picotorrent/application.cpp Outdated Show resolved Hide resolved
src/picotorrent/resources.rc Outdated Show resolved Hide resolved
src/picotorrent/ui/dialogs/preferencesgeneralpage.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vktr vktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job on the refactoring - it's mostly formatting and naming fixes that needs to be addressed other than passing a boolean around rather than a full configuration instance. I've left a few suggestions! 😄

src/picotorrent/application.cpp Outdated Show resolved Hide resolved
src/picotorrent/core/configuration.cpp Show resolved Hide resolved
src/picotorrent/core/configuration.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/console.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/console.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.cpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.hpp Outdated Show resolved Hide resolved
src/picotorrent/ui/widgets/pieceprogressbar.hpp Outdated Show resolved Hide resolved
@vktr vktr merged commit 79644e8 into picotorrent:master May 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants