updating graphics fails for "fresh" install

[Pidgeot]

This might only affect cases where there is no existing settings file to read.

#!text
Exception in Tkinter callback
Traceback (most recent call last):
  File "/usr/lib/python2.7/lib-tk/Tkinter.py", line 1489, in __call__
    return self.func(*args)
  File "/.../tkgui.py", line 749, in <lambda>
    command=lambda: self.install_graphics(graphicpacks))
  File "/.../tkgui.py", line 1497, in install_graphics
    self.load_params()
  File "/.../tkgui.py", line 1160, in load_params
    self.lnp.load_params()
  File "./lnp.py", line 109, in load_params
    self.settings.read_settings()
  File "/.../settings.py", line 186, in read_settings
    self.read_file(filename, self.in_files[files], len(files) == 1)
  File "/.../settings.py", line 225, in read_file
    self.settings[field] = match.group(1)
AttributeError: 'NoneType' object has no attribute 'group'

Recommend additional guard against regex match failing; attached patch is against tip.

[Issue created by beltorak: 2014-09-01]
[Last updated on bitbucket: 2014-09-02]

[Comment created by Pidgeot: 2014-09-02]
Avoid crashing if an expected field cannot be found, print warning instead (fixes #21)

→ <>

[Comment created by beltorak: 2014-09-02]
You are right; the obsidian pack is just not updated for DF2014 (0.40); The wiki needs updating. I found the linux LNP at http://www.bay12forums.com/smf/index.php?topic=140966 which led me to an updated collection of graphics packs at https://github.com/fricy/DFgraphics. I'll stick to those.

This issue can be closed or rejected.

Thanks

[Comment created by beltorak: 2014-09-01]
It's the obsidian graphics set, and it only happens when I try to save. After launching a few times the problem went away, which leads me to think that it only happens when it can't find the setting.

Sorry about the noise on the issue tracker, i realized i made the guard bypass the force_bool check; but you seem to have it now.

Graphics pack is from http://dffd.wimbli.com/download.php?id=7728&f=%5B16x16%5D+Obsidian+%28v.0.8%29.zip

Thanks

[Comment created by Pidgeot: 2014-09-01]
What version of DF were you trying to install to? The pack seems to be for 0.34; if you installed it over a 0.40 DF, that explains what went wrong. The program expects to find all the tags it originally saw in both d_init.txt and init.txt; if you installed a pack for an older version, that explains the break. (It still needs to be fixed, but in that case I should probably throw a warning.)

[Comment created by Pidgeot: 2014-09-01]
Going by the stack trace, this happened after a graphics pack install - or at the very least after some modification of some files, because otherwise, this problem would have shown itself on launch. The pack you installed may be broken (or at least missing something that I expect it to have).

I'm putting in a fix similar to your patch now, but before pushing it online, I'd like to see the pack itself to figure out why it's breaking in the first place - a link would be much appreciated.

[Comment created by beltorak: 2014-09-01]
that could be it; let me see what happens with phoebus.