Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update check non-blocking #38

Closed
Pidgeot opened this issue Apr 4, 2020 · 0 comments
Closed

Make update check non-blocking #38

Pidgeot opened this issue Apr 4, 2020 · 0 comments

Comments

@Pidgeot
Copy link
Owner

Pidgeot commented Apr 4, 2020

Here a user describes:

If the device isn't connected [the PyLNP] seems to hang for about a min or two and then throws an error when the connection timeouts -- you can ignore the error and the pack works properly but the delay gets a bit annoying after awhile.

Adding an option to disable update checking would be a viable if inelegant fix - though still desirable from eg a privacy perspective.

Making the update check non-blocking would be a cleaner resolution of this issue. If an update was found, it could interrupt to pop up a notification; if no update was found or the check fails it passes silently.

[Issue created by PeridexisErrant: 2014-09-18]
[Last updated on bitbucket: 2014-09-19]

[Comment created by Pidgeot: 2014-09-19]
Perform update check in separate thread (fixes #25)

→ <<cset 8af740bcaa20>>

[Comment created by Pidgeot: 2014-09-18]
Agreed, this is definitely something that needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant