forked from knative/eventing
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make SubscriptionSpec.Delivery mutable (knative#1611)
Just by creating a subscription in v0.24 and upgrading the cluster to 0.26, the webhook starts throwing errors like this: ``` admission webhook "validation.webhook.eventing.knative.dev" denied the request: validation failed: Immutable fields changed (-old +new): spec {v1.SubscriptionSpec}.Delivery.DeadLetterSink.Ref.Namespace: -: "" +: "kc-broker-v1-dlq" ``` In addition, Subscription.Spec.Delivery wasn't meant to be immutable, in fact, TriggerSpec.Spec.Delivery is mutable. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
- Loading branch information
Showing
2 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters