-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Encoded entities in Logs to DataDog #26
Comments
Hi @JanThiel ! Regarding your issue, that's very strange. The only remembrance I have concerning this type of subject is this commit. But it's about New Relic, not DataDog. Let me investigate it… |
If it helps, it is not just the message, it is also within the
Seems to be something more general. |
Yes. It seems Datadog have changed something on its side. I will try to globally fix it for the next version - even if I don't know how at this time 🤣 |
Let me raise a ticket with Datadog and see what they reply :-) |
Ah thanks. That's a good idea. |
hi guys, i can confirm same issue with datadog |
Hi @JanThiel ! |
@Pierre-Lannoy Nope ... awaiting feedback from their technical department. |
@Pierre-Lannoy Here is the feedback from DD. Can you suggest a way how to deliver what they request?
|
Hello @JanThiel and thanks for letting me know about DataDog's answer. Well, anyway, they're not going to do a rollback. So it's up to DecaLog to adapt… I will make a POC to decode HTML entities for all fields sent to DataDog and will let you know. |
I understood their request just as a request to prove that Decalog does not encode. |
Wowowowo. Found it! It's coming from DecaLog and it was introduced by PHP 8.1 compatibility. So now, I have choice to 8.1 compatibility or correct strings 🤣 |
OK. That's fixed. Will be in the next release (3.5.0). |
Glad to hear you found and fixed it 👍🎉 |
3.5.0 is out! Can you tell me if it's ok for you now? |
Thank you very much 😊 I will get back with feedback within the next couple of days |
I can confirm this is fixed with 3.5.0 🥳 |
Great! Thanks for the feedback 👍🏼 |
Describe the bug
Hey @Pierre-Lannoy, its me again ;-) Hope you are doing well!
Since the last update to decalog 3.4.1 we encounter HTML encoded entities in our DataDog logs:
The
“
and”
are new. It also happens for other HTML encodeable entities whenever they are part of the submitted log message.I am quite certain this was not the case before we updated to 3.4.1. Yet I cannot completely rule out a change on Datadog side.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The string should appear in DataDog in its natural beauty without these crude transformations.
The text was updated successfully, but these errors were encountered: