Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carriage return in notes not working #172

Open
shauryashaurya opened this issue Jul 13, 2022 · 2 comments
Open

carriage return in notes not working #172

shauryashaurya opened this issue Jul 13, 2022 · 2 comments

Comments

@shauryashaurya
Copy link

As always betterfountain is wonderful to use.
Thank you!

I recently ran into an issue and wanted to bring it to your attention
(I can try my hand at a pull req if am able to figure out where/how to fix this - your guidance would be very welcome here)

A single line note works perfectly, however a multi-line note (carriage return) does not.
for e.g.,
[[This note works perfectly]]

but

[[This is
not recognized
as

a
note]]

Per the specification, carriage returns are supported in notes.

Thanks again for all your work! So awesome! :)

@shauryashaurya
Copy link
Author

Some more info:

Seems like the note_inline regular expression in afterwriting-parser.ts is working fine by itself.
There may be a conflict with the rest of the parser.

Here are the tests I ran:
Testing the note_inline regex

@piersdeseilligny
Copy link
Owner

Hi, thanks for reporting this and apologies for the slow response!

It's normal for

[[This is
not recognized
as

a
note]]

to not be recognized as a note (notes can't contain empty lines), however the following:

[[this is a note
across several lines]]

really should be. I'm not sure what's happening here, but I'il investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants