Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme undefined in dialog #177

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented May 18, 2023

Fix #176

Copy link
Contributor

@rafaqz rafaqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM. Must have missed those.

The idea was to always pass around know state like the theme because getting it again from globals isnt type stable.

@mkitti
Copy link
Contributor Author

mkitti commented May 18, 2023

Thanks for looking this over.

@beorostica
Copy link

We are really interested in using this feature soon for KomaMRI.jl.
When would this be merged in a new version of IntectBase and updated in the julia registries?

@mkitti
Copy link
Contributor Author

mkitti commented May 18, 2023

We'll need @piever to move forward. Actually, I'm not sure who has merge capabilities here.

@piever piever merged commit 190d691 into JuliaGizmos:master May 18, 2023
@piever
Copy link
Collaborator

piever commented May 18, 2023

So, I'm happy to tag a release, but I agree that it is not ideal that I'm the only person with merging privileges here. Should I simply move this repo to JuliaGizmos? It seems like the more robust solution going forward.

cc: @travigd, @shashi, @rafaqz

@mkitti
Copy link
Contributor Author

mkitti commented May 18, 2023

Should I simply move this repo to JuliaGizmos?

I think this makes sense especially if this is not being very actively developed at the moment.

@shashi
Copy link
Member

shashi commented May 26, 2023

@piever Sounds fine to me as long as you will still retain merge privileges :)

@piever
Copy link
Collaborator

piever commented Jun 7, 2023

Perfect, I've just moved the repo to JuliaGizmos. Does this PR warrant a release or should we wait for #178 to be ready?

@mkitti
Copy link
Contributor Author

mkitti commented Jun 7, 2023

I believe it does warrant a release. Users are reporting issues with Interact.jl:
JuliaGizmos/Interact.jl#414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog fails since theme is undefined
5 participants