-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix theme undefined in dialog #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM. Must have missed those.
The idea was to always pass around know state like the theme because getting it again from globals isnt type stable.
Thanks for looking this over. |
We are really interested in using this feature soon for KomaMRI.jl. |
We'll need @piever to move forward. Actually, I'm not sure who has merge capabilities here. |
I think this makes sense especially if this is not being very actively developed at the moment. |
@piever Sounds fine to me as long as you will still retain merge privileges :) |
Perfect, I've just moved the repo to JuliaGizmos. Does this PR warrant a release or should we wait for #178 to be ready? |
I believe it does warrant a release. Users are reporting issues with Interact.jl: |
Fix #176