Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#68 breaks historical legends in mip plots (and therefore compare scenarios) #73

Closed
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Jun 29, 2023 · 1 comment
Assignees
Labels

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

#66 works

devtools::install_github('pik-piam/mip', 'c64c7ed')
library(mip)
library(tidyverse)

d <- tribble(
  ~model,   ~scenario,      ~region,   ~variable,   ~unit,   ~period,   ~value,
  'foo',    'foo',          'foo',     'foo',       'foo',   1,         1,
  'foo',    'foo',          'foo',     'foo',       'foo',   2,         2,
  'bar',    'historical',   'foo',     'foo',       'foo',   1,         1,
  'bar',    'historical',   'foo',     'foo',       'foo',   2,         4)

showLinePlots(d, 'foo', mainReg = 'foo')

image

#68 does not

devtools::install_github('pik-piam/mip', 'b8a98a7')
library(mip)
library(tidyverse)

d <- tribble(
  ~model,   ~scenario,      ~region,   ~variable,   ~unit,   ~period,   ~value,
  'foo',    'foo',          'foo',     'foo',       'foo',   1,         1,
  'foo',    'foo',          'foo',     'foo',       'foo',   2,         2,
  'bar',    'historical',   'foo',     'foo',       'foo',   1,         1,
  'bar',    'historical',   'foo',     'foo',       'foo',   2,         4)

showLinePlots(d, 'foo', mainReg = 'foo')

image

@orichters
Copy link
Contributor

Was already fixed in #75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants