-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): bump eslint from 3.19.0 to 6.6.0 #84
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 3.19.0 to 6.6.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v3.19.0...v6.6.0) Signed-off-by: dependabot[bot] <support@github.com>
a20d432
to
188ce3a
Compare
Did we enable this? The docs say this:
|
I had the same thought when it came in this morning but apparently github opted everyone in. I opted out, but after this is already made. I figured I'd just get eslint updated tonight (and the corresponding style changes). |
Interesting, in general it seems like we want this feature, just slowly adopted, right? If we are going to go through any round of style updates, do we just want to bite the bullet and use |
Correct. I turned it off for now just as a stop gap to figure out what it is / does.
For this module, being actual standard does change the public api in that it wants the methods renamed from snake_case to camelCase. |
👍
We can always add |
Yes. Just noted why it was not already using standard :) Ideally we don't want to have those, of course :) I was thinking of just applying standard on the 2.0 branch, though, with the whitespace changes on the master branch to make the 2.0 PR not so noisy. |
Ahh, I miss-understood.
Agreed.
Seems like a great approach! |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps eslint from 3.19.0 to 6.6.0.
Release notes
Sourced from eslint's releases.
Changelog
Sourced from eslint's changelog.
Commits
879c373
6.6.0c8ba30a
Build: changelog update for 6.6.039dfe08
Update: false positives in function-call-argument-newline (fixes #12123) (#12...4d84210
Update: improve report location for no-trailing-spaces (fixes #12315) (#12477)c6a7745
Update: no-trailing-spaces false negatives after comments (fixes #12479) (#12...0bffe95
Fix: no-misleading-character-class crash on invalid regex (fixes #12169) (#12...c6a9a3b
Update: Add enforceForIndexOf option to use-isnan (fixes #12207) (#12379)364877b
Update: measure plugin loading time and output in debug message (#12395)1744fab
Fix: operator-assignment removes and duplicates comments (#12485)52ca11a
Fix: operator-assignment invalid autofix with adjacent tokens (#12483)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot ignore this [patch|minor|major] version
will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.