Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Default BSI base value to min, max, or 0 depending on the min/max range #2050

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

travisturner
Copy link
Member

Overview

The BSI base value determined by FieldOptions.Base was defaulting to 0 (except in cases of migration from v1 of BSI). This PR changes the logic to set the base to either min, max, or 0 depending on the range of min/max.

Fixes #2013

Pull request checklist

  • I have read the contributing guide.
  • I have agreed to the Contributor License Agreement.
  • I have updated the documentation.
  • I have resolved any merge conflicts.
  • I have included tests that cover my changes.
  • All new and existing tests pass.
  • Make sure PR title conforms to convention in CHANGELOG.md.
  • Add appropriate changelog label to PR (if applicable).

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.
  • Make sure PR title conforms to convention in CHANGELOG.md.
  • Make sure PR is tagged with appropriate changelog label.

@travisturner
Copy link
Member Author

I just realized we may need to apply this same logic to the migration code in Field.loadMeta() as well.

@travisturner
Copy link
Member Author

I pushed another commit to apply that same logic to the migration from v1 code.

benbjohnson
benbjohnson previously approved these changes Jul 31, 2019
field.go Outdated Show resolved Hide resolved
@travisturner travisturner merged commit a5aa6e4 into FeatureBaseDB:master Jul 31, 2019
@travisturner travisturner deleted the bsi-base-value branch July 31, 2019 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

int range bug in Pilosa
3 participants