Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ENV from Dockerfile #32

Closed
pilosus opened this issue Jan 16, 2022 · 0 comments · Fixed by #33
Closed

Remove ENV from Dockerfile #32

pilosus opened this issue Jan 16, 2022 · 0 comments · Fixed by #33

Comments

@pilosus
Copy link
Owner

pilosus commented Jan 16, 2022

Using ENV prevents the app from using the default config values in case an env is not provided.

An end-user always can pass the env via docker run -e ENV=VAL ... if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant