Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract/future.js defaults #74

Open
andreivirtosu opened this issue Oct 20, 2016 · 3 comments
Open

contract/future.js defaults #74

andreivirtosu opened this issue Oct 20, 2016 · 3 comments

Comments

@andreivirtosu
Copy link

IMO doesn't make sense to put default values in there, it can lead to hard to track errors.

@pilwon
Copy link
Owner

pilwon commented Oct 25, 2016

@yandreiy Please feel free to submit PR to fix this. Thanks-

@buzzcloudau
Copy link
Contributor

All of the contracts have similar defaults. It would be confusing to have one behave differently. Maybe an update to the documentation would be better?

@tredondo
Copy link
Contributor

tredondo commented Dec 7, 2018

Destructured parameters would be great too. See #137. Also, the default exchange for futures should be 'GLOBEX', not 'ONE'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants