[Improvement]: Move grid data related functions from pimcore/pimcore v11.3 #457
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
kingjia90
changed the title
|
|
||
| if (method_exists($object, $getter)) { | ||
| /** @var Classificationstore $classificationStoreData */ | ||
| $classificationStoreData = $object->$getter(); |
Check warning
Code scanning / SonarCloud
Reflection should not be vulnerable to injection attacks Medium
| $value = $object->$getter(); | ||
| if (!empty($value) && !empty($brickType)) { | ||
| $getBrickType = 'get' . ucfirst($brickType); | ||
| $value = $value->$getBrickType(); |
Check warning
Code scanning / SonarCloud
Reflection should not be vulnerable to injection attacks Medium
| $value = $localizedFields->getLocalizedValue($brickDescriptor['brickfield']); | ||
| } else { | ||
| $brickFieldGetter = 'get' . ucfirst($brickKey); | ||
| $value = $value->$brickFieldGetter(); |
Check warning
Code scanning / SonarCloud
Reflection should not be vulnerable to injection attacks Medium
|
Please retry analysis of this Pull-Request directly on SonarCloud |
There was a problem hiding this comment.
Please check if we can make the commented classes @internal. The rest LGTM - so we can merge it after checking 👍
|
Can be merged right before creating the release to avoid problems with the testing pipelines. |
|
Resolves pimcore/pimcore#15971