Fix error undefined index 'analytics' - related to #12911 (#13594)

pimcore · Nov 18, 2022 · b92e50e · b92e50e
1 parent c97929a
commit b92e50e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/lib/Analytics/Google/Config/Config.php b/lib/Analytics/Google/Config/Config.php
@@ -31,14 +31,7 @@ public function __construct(array $config)
 
     public static function fromReportConfig(array $reportConfig): self
     {
-        $config = null;
-        if ($reportConfig['analytics']) {
-            $config = $reportConfig['analytics'];
-        } else {
-            $config = [];
-        }
-
-        return new self($config);
+        return new self($reportConfig['analytics'] ?? []);
     }
 
     public function getConfig(): array

diff --git a/lib/Analytics/Google/Config/ConfigProvider.php b/lib/Analytics/Google/Config/ConfigProvider.php
@@ -59,11 +59,6 @@ protected function loadDefaultConfigObject(): array
     {
         $reportConfig = \Pimcore\Config::getReportConfig();
 
-        $config = $reportConfig['analytics'];
-        if (!is_array($config)) {
-            $config = [];
-        }
-
-        return $config;
+        return $reportConfig['analytics'] ?? [];
     }
 }