Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK]: Remove Pimcore\Config\Config #12911

Merged
merged 7 commits into from
Aug 25, 2022
Merged

[TASK]: Remove Pimcore\Config\Config #12911

merged 7 commits into from
Aug 25, 2022

Conversation

mcop1
Copy link
Contributor

@mcop1 mcop1 commented Aug 18, 2022 •
edited

Resolves #12477

@mcop1
[TASK] Remove Pimcore\Config\Config
6dfdba9
@mcop1
Remove Pimcore\Config\Config
77cd75b
@mcop1
Merge branch '11.x' into 12477-remove-pimcoreconfigconfig
b71ed3a 
# Conflicts:
#	doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
@mcop1 mcop1 added this to the 11.0.0 milestone Aug 18, 2022
@mcop1 mcop1 marked this pull request as draft August 18, 2022 10:36
@github-actions
Copy link

github-actions bot commented Aug 18, 2022 •
edited by robertSt7

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@mcop1 mcop1 mentioned this pull request Aug 18, 2022
Closed
@mcop1
[TASK] Remove Pimcore\Config\Config
0d74ecc 
Fixed PHPStan issues (doctypes and toArray method)
@mcop1
[TASK] Remove Pimcore\Config\Config
58fe096 
Fixed PHPStan issues, property access
@mcop1 mcop1 marked this pull request as ready for review August 22, 2022 06:33
@mcop1
[TASK]: Remove Pimcore\Config\Config
917f7fc 
Updated documentation
@mcop1
Merge branch '11.x' into 12477-remove-pimcoreconfigconfig
e403365 
# Conflicts:
#	doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
@robertSt7 robertSt7 merged commit 175fd47 into 11.x Aug 25, 2022
@robertSt7 robertSt7 deleted the 12477-remove-pimcoreconfigconfig branch August 25, 2022 04:38
This was referenced Aug 25, 2022
Closed
Closed
@kingjia90 kingjia90 mentioned this pull request Sep 1, 2022
Merged
mcop1 added a commit that referenced this pull request Sep 2, 2022
@mcop1
[TASK]: Remove Pimcore\Config\Config (#12911)
f9821af 
* [TASK] Remove Pimcore\Config\Config

* Remove Pimcore\Config\Config

* [TASK] Remove Pimcore\Config\Config
Fixed PHPStan issues (doctypes and toArray method)

* [TASK] Remove Pimcore\Config\Config
Fixed PHPStan issues, property access

* [TASK]: Remove Pimcore\Config\Config
Updated documentation
aashan10 pushed a commit to aashan10/pimcore that referenced this pull request Sep 22, 2022
@mcop1 @aashan10
[TASK]: Remove Pimcore\Config\Config (pimcore#12911)
b05d740 
* [TASK] Remove Pimcore\Config\Config

* Remove Pimcore\Config\Config

* [TASK] Remove Pimcore\Config\Config
Fixed PHPStan issues (doctypes and toArray method)

* [TASK] Remove Pimcore\Config\Config
Fixed PHPStan issues, property access

* [TASK]: Remove Pimcore\Config\Config
Updated documentation
dvesh3 added a commit that referenced this pull request Nov 16, 2022
@dvesh3
Fix error undefined index 'analytics' - related to #12911
1ae3775
@dvesh3 dvesh3 mentioned this pull request Nov 16, 2022
Merged
robertSt7 pushed a commit that referenced this pull request Nov 18, 2022
@dvesh3
Fix error undefined index 'analytics' - related to #12911 (#13594)
b92e50e
@blankse blankse mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusch brusch brusch left review comments

@kingjia90 kingjia90 kingjia90 left review comments

Assignees

@robertSt7 robertSt7

Labels
BC-BREAK Task
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

Remove Pimcore\Config\Config
4 participants
@mcop1 @brusch @kingjia90 @robertSt7