Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets Versioning issue with different mime types #8316

Closed
Maksonis opened this issue Mar 2, 2021 · 2 comments
Closed

Assets Versioning issue with different mime types #8316

Maksonis opened this issue Mar 2, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@Maksonis
Copy link
Contributor

Maksonis commented Mar 2, 2021

When I upload new asset version, which have different mime type as original one, I lose original one.

Steps to reproduce (on live pimcore demo):

  1. Take asset: http://demo.pimcore.fun/admin/login/deeplink?asset_69_image (it's a jpg)
    image

  2. Upload new version: png image
    image

  3. Everything looks good, but filename of old version is png. When publish old version you get filename as png, but mime type image/jpeg
    image

This is issue when creating svg version of eps file, and want to revert back eps one

@brusch brusch added this to the 10.0.1 milestone May 11, 2021
@brusch brusch added the Bug label May 11, 2021
@dvesh3
Copy link
Contributor

dvesh3 commented May 12, 2021

this is intentional behavior for cases like when you publish a version after rename or moving an asset. please see https://github.com/pimcore/pimcore/blob/10.x/models/Asset.php#L1878

@brusch "upload new version" should be used to just replace the content. wdyt?

Edit: I got this wrong...so we need to fix mime type(from current state) not the filename.

@brusch
Copy link
Member

brusch commented May 26, 2021

Fixed by #9230

@brusch brusch closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants