Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Remove Pimcore\Config\Config, adds missing $config assignment on cache init #13032

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

kingjia90
Copy link
Contributor

Changes in this pull request

Follow up #12911

Additional info

More details on #12911 (comment)

@kingjia90 kingjia90 added the Task label Sep 1, 2022
@kingjia90 kingjia90 added this to the 11.0.0 milestone Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@mcop1 mcop1 self-assigned this Sep 1, 2022
@mcop1 mcop1 merged commit 6ac0da7 into 11.x Sep 1, 2022
@kingjia90 kingjia90 deleted the fix_config_cache_init branch September 1, 2022 13:20
mcop1 added a commit that referenced this pull request Sep 2, 2022
… on cache init (#13032)

* Fix: added a missing variable assignment

* [Task]: Remove Pimcore\Config\Config, adds missing $config assignment on cache init

Co-authored-by: mcop1 <marco.perberschlager@pimcore.com>
aashan10 pushed a commit to aashan10/pimcore that referenced this pull request Sep 22, 2022
… on cache init (pimcore#13032)

* Fix: added a missing variable assignment

* [Task]: Remove Pimcore\Config\Config, adds missing $config assignment on cache init

Co-authored-by: mcop1 <marco.perberschlager@pimcore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants