Make it possible to have not all languages required #16835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
Review Checklist
|
Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
|
@matthiashamacher nice addition, thank you! Could you please have a look at the conflict? |
blankse
reviewed
Apr 5, 2024
Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de> # Conflicts: # lib/SystemSettingsConfig.php
Remove the default value of the config and returning all valid languages if there are no required languages set Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
|
matthiashamacher
added a commit
to matthiashamacher/admin-ui-classic-bundle
that referenced
this pull request
Apr 12, 2024
Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
|
Thanks again, really nice addition 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #2958
Additional info
This PR adds the core functionality needed to have not all languages mandatory. For that we add a new config node
required_languagesto thepimcore.generalnode, which stores similar to thevalid_languagesall required languages in an array. This data is then also made available to the frontend via theSystemSettingsConfig::prepareSystemConfig()function.In the
checkValidity()function of the Localizedfield we then not check all languages but only the required ones