-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Add Gotenberg support to define screenshot size #17023
Conversation
Review Checklist
|
@@ -6,6 +6,8 @@ | |||
- Unused setting `general.language` has been deprecated. | |||
#### [Listing] | |||
- The methods `setOrder()` and `setOrderKey()` throw an `InvalidArgumentException` if the parameters are invalid now. | |||
#### [Html to Image] | |||
- [Gotenberg] Bumped the lowest requirement of `gotenberg-php` from `^2.0` to `^2.4` to add support of passing screenshot size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this phrasing sounds clear that the minimum ^1.1
is still supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that it's potentially a little bit strange, but I would say it's fine. Some kind of convoluted sentence which describes the reason for the ^1.1 support wouldn't make it better, so let's write it like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's resolve the conflict and then merge it! Thanks!
Quality Gate passedIssues Measures |
Changes in this pull request
Resolves #17009