Replace prototype-light.js

[kirjavascript]

Changes in this pull request

Resolves #2974

Additional info

Work in progress - additional bugfixes to follow

See the previous PR for more information

[brusch]

Let's continue the discussion here.
So there seems to be an issue with the scopes:

TypeError: Cannot read property 'bind' of undefined
    at Function.getLayout (properties.js?_dc=285:64)
    at Function.<anonymous> (class.js?_dc=285:67)
    at Function.getLayout (properties.js?_dc=285:38)
    at klass.getLayout (class.js?_dc=285:22)
    at klass.getTabPanel (page.js?_dc=285:72)
    at klass.addTab (page_snippet.js?_dc=285:35)
    at klass.getDataComplete (document.js?_dc=285:44)
    at Object.callback (ext-all-debug.js?_dc=285:8174)
    at constructor.onComplete (ext-all-debug.js?_dc=285:24674)
    at constructor.onStateChange (ext-all-debug.js?_dc=285:24631)

[kirjavascript]

Having trouble reproducing that, how did you trigger the error?

[dpfaffenbauer]

Just for reference: Object.extend is important cause of BC. Plugins may use that function and removing it will cause issues.

[kirjavascript]

@dpfaffenbauer is a solution for that simply providing an optional backwards compat shim?

(It would literally just be a small variation on the previous prototype-light.js file)

[dpfaffenbauer]

@kirjavascript well, but Pimcore needs to require that shim, just providing it doesn't help, it would still be a BC break.

[kirjavascript]

@dpfaffenbauer in that case requiring the shim would have the same effect as not removing prototype-light at all

I'm not sure it's possible to complete this task without breaking BC for plugins then :/

[brusch]

I think first of all we should get it working, then we can discuss about the BC :-)

@kirjavascript the error occurs when opening a document page

[brusch]

@kirjavascript are you able to reproduce it?

[kirjavascript]

@brusch yeah, I don't know why it wasn't breaking before - it's actually easy to reproduce

in the conversion process I seemingly lost the context at some point in the addMethods function - should be fixed now

[brusch]

@kirjavascript Did a lot of testing and it seems it's all done now. Good job!

[brusch]

added upgrade notes regarding BC breaks

[dpfaffenbauer]

Replacement could partly come from ExtJS.

Ext.isArray, Ext.isFunction, Ext.isString, Ext.isDefined and so on.

[brusch]

Thanks for the hint, added them in detail

[dpfaffenbauer]

I still don't like the BC break, but it is not too bad and it is documented. So there is nothing more to add from my side.

[brusch]

@kirjavascript can you try to resolve the conflicts? Thanks!

[kirjavascript]

Conflicts resolved.

Added alternatives for Array methods into the docs.

As for the Function prototype methods I'm not able to recreate some of the things in a concise way, so if alternatives cannot be found in Ext we could possibly point to another library that contains them?

This might not be important though, since I imagine these methods are rarely if ever used

[brusch]

@kirjavascript I've changed the base of this PR to the pimcore:v5.4.0-dev branch, so we can merge it. Unfortunately your fork is outdated and doesn't have the v5.4.0-dev branch, so I'm unable to resolve the conflicts, can you help me out once again?

Thank you very much!

[kirjavascript]

@brusch added v5.4.0-dev to my fork - do I need to merge from v5.4.0-dev to replace_prototype-light.js too?

[brusch]

Yep, I think thats necessary to resolve the conflicts.

[brusch]

@kirjavascript Thanks, I was now able to merge it - so nothing else to do for you.