[Web2print] Fix background PDF generation with wkhtmltopdf on OS X #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" error when generating PDFs on OS x using wkthmltopdf
|
|
|
ok, in my opinion: Pimcore doesn't support Mac OS as operating system, therefore Pimcore should not care about that. OSX also isn't a suitable server infrastructure to run Pimcore on. BTW: I am also working on Mac and I never had issues with that before. |
|
I wouldn't use OS X in production, but seems suitable for me as dev environment. Chances to break anything with this bugfix are fairly small. |
|
True, but thats not my concern. My concern is that this is another piece of code that has to be maintained and refactored as well some day. "just to support osx". |
brusch
reviewed
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "nohup: can't detach from console: Inappropriate ioctl for device" error when generating PDFs on OS x using wkthmltopdf
Changes in this pull request
Resolves #4022
Additional info