Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Fix Compile Error in Symfony 4 #4932

Merged
merged 2 commits into from
Sep 4, 2019
Merged

[Tests] Fix Compile Error in Symfony 4 #4932

merged 2 commits into from
Sep 4, 2019

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Sep 3, 2019

Fix error in Travis tests:

Fatal error: Declaration of Pimcore\Tests\Cache\Pool\Traits\CacheItemPoolTestTrait::tearDownAfterClass() must be compatible with Symfony\Component\Cache\Tests\Adapter\FilesystemAdapterTest::tearDownAfterClass(): void in /home/travis/build/pimcore/pimcore/tests/cache/Pool/SymfonyProxy/FilesystemAdapterProxyTest.php on line 15

@brusch
Copy link
Member

brusch commented Sep 4, 2019

Grazie Mille 👌

@brusch brusch merged commit 5dd0daf into pimcore:master Sep 4, 2019
@brusch brusch self-assigned this Sep 4, 2019
@brusch brusch added this to the 6.2.0 ("Hefeweizen") milestone Sep 4, 2019
@blankse blankse deleted the patch-2 branch September 5, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brusch brusch

Labels
None yet
Projects
None yet
Milestone
6.2.0 ("Hefeweizen")
Development

Successfully merging this pull request may close these issues.
2 participants
@blankse @brusch