Support Custom HTML in Workflow Notes #7667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param $customHtmlService | ||
| */ | ||
| public function setCustomHtmlService($customHtmlService) { | ||
| if ($customHtmlService instanceof AbstractCustomHtmlService) { |
There was a problem hiding this comment.
instanceof CustomHtmlServiceInterface
There was a problem hiding this comment.
sorry, no, actually that is fine.... But the AbstractCustomHtmlService should be a interface with it's extra functions, right?
There was a problem hiding this comment.
You mean an additional interface for getTransitionName(), getActionName(), getPosition() and so forth?
Don't know if this is necessary, as those fields are intended to be mainly used within the class.
There was a problem hiding this comment.
not sure honestly... I always use separate interfaces, also for this use-cases. What if a custom Symfony (not Pimcore) Workflow tries to do this?
dvesh3
reviewed
Dec 23, 2020
doc/Development_Documentation/07_Workflow_Management/01_Configuration_Details/README.md
Outdated
Show resolved
Hide resolved
doc/Development_Documentation/07_Workflow_Management/01_Configuration_Details/README.md
Outdated
Show resolved
Hide resolved
|
@chilladelia thanks a lot! |
|
Thanks for merging! |
roland4432
pushed a commit
to roland4432/pimcore
that referenced
this pull request
Apr 1, 2021
* Support custom HTML in transition notes. * Support global actions. * Support global actions. * Support multiple custom HTML labels within one renderer. * Set default value for position. * Correctly inject custom HTML service properties via compiler pass. * Fix annotation. * Improve comments. * Add autowiring / fix build issue. * Support workflow modal without note. * Apply suggestions from code review Co-authored-by: agruenwald <a.gruenw@gmail.com> Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
roland4432
pushed a commit
to roland4432/pimcore
that referenced
this pull request
Apr 1, 2021
roland4432
pushed a commit
to roland4432/pimcore
that referenced
this pull request
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the configuration of renderers to dynamically output HTML markup in Workflow notes.
This is useful to show summaries and alike, before the user is actually going to commit the workflow change.
Example:
Notes can be placed on three different positions (top, center, bottom) for both transitions, and global actions.
A custom renderer service and a default position can be configured in the workflow configuration yml.