Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into kia_uvo #4

Open
fuatakgun opened this issue Jul 27, 2022 · 5 comments
Open

Merge into kia_uvo #4

fuatakgun opened this issue Jul 27, 2022 · 5 comments

Comments

@fuatakgun
Copy link

Do you think we can merge this work into Kia Uvo integration? As you might noticed, it supports Kia and Hyundai brands in multiple regions and this could be a perfect fit to expand into.

@PimDoos
Copy link
Owner

PimDoos commented Jul 27, 2022

Sounds like a good plan! Although it should be noted this is not technically Kia UVO. The MijnKia version this integration is made for supports less features than the newer vehicles with UVO modems (no climate control, no remote start etc).
I'll be happy to help integrating it into kia_uvo!

@PimDoos
Copy link
Owner

PimDoos commented Sep 27, 2022

Since hacktoberfest is coming up, mind adding a hacktoberfest flag in your repo? I'll see if I can make some pulls to merge this into kia_uvo :)

@cdnninja
Copy link

Just ran into this and agree with fuatakgun. Would be happy to have this added to the list of supported car types. kia_uvo has turned into multiple kia/hyundai cars. We also have hyund which the hope was to become the base for version 2 of kia_uvo.

@cdnninja
Copy link

I have contributor support to the kia_uvo repo. Is it too late for the hacktoberfest flag to help you out?

@PimDoos
Copy link
Owner

PimDoos commented Oct 27, 2022

I can give it a try this weekend, but I'm not sure whether I can pull it off within hacktober. Much of the base code (inspiration) came from the kia_uvo integration though, before I turned it into a fully async integration, so maybe some of the old sync versions will be easier to port.

I already completed hacktober though, so that's not a blocking issue for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants