Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite due comparisons don't consider timezones #92

Closed
WhyNotHugo opened this issue Feb 12, 2017 · 3 comments
Closed

sqlite due comparisons don't consider timezones #92

WhyNotHugo opened this issue Feb 12, 2017 · 3 comments
Assignees
Labels

Comments

@WhyNotHugo
Copy link
Member

Since dates are stored as strings in sqlite, timezones aren't taking properly accounted for when comparing datetimes. (this was revealed by df24af8)

@WhyNotHugo WhyNotHugo self-assigned this Feb 12, 2017
@WhyNotHugo
Copy link
Member Author

Actually, I found the issue and it's not that: the actual issue is that the test is badly written assuming that the current timezone is CET.

Still, my code was broken and the above commit exposed it. 😢

@untitaker
Copy link
Member

Impressed that you found this so quickly! 👍

@WhyNotHugo
Copy link
Member Author

Thanks. TBH, I recalled that sqlite had no proper datetime format, but rather stored strings, so I'd assumed it somehow stemmed from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants