Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip ignored children in RenderObject.visitChildrenForSemantics #32

Closed
Albert221 opened this issue Nov 1, 2023 · 2 comments
Closed

Skip ignored children in RenderObject.visitChildrenForSemantics #32

Albert221 opened this issue Nov 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Albert221
Copy link

As in the title, if we don't paint children by calling BoxyChild.ignore() inside a BoxyDelegate, we most likely don't want to include it in the semantics tree, so that the screen readers won't bother with the children we didn't want to paint.
@pingbird pingbird added the bug Something isn't working label Nov 1, 2023
@pingbird
Copy link
Owner

pingbird commented Nov 1, 2023

Should be fixed in 2.1.3, Thanks!

@pingbird pingbird closed this as completed Nov 1, 2023
@Albert221
Copy link
Author

That was a quick fix, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pingbird @Albert221