Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

summary: add real time cost to log collector (#480) #486

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #480 to release-4.0


Signed-off-by: Hillium maruruku@stu.csust.edu.cn

What problem does this PR solve?

implement #478

What is changed and how it works?

We make serval changes to make the log of time cost correct:

  1. collect kv and size each time of importing.

    br/pkg/restore/import.go

    Lines 328 to 331 in d9d6207

    }
    summary.CollectSuccessUnit(summary.TotalKV, 1, file.TotalKvs)
    summary.CollectSuccessUnit(summary.TotalBytes, 1, file.TotalBytes)
    }
  2. a log of real time cost is added to the summary.
  3. collect the success unit when checksumming, so the total cost field would be (the time of restoring + the time of checksumming) instead of just the time of restoring.

Check List

Tests
image

  • Manual test (add detailed scripts or steps below)

Release Note

  • Add real time cost to log.

Hillium added 3 commits September 2, 2020 13:49
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Sep 2, 2020
@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Sep 3, 2020
@kennytm
Copy link
Collaborator

kennytm commented Sep 3, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 89879c7 into pingcap:release-4.0 Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants