Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb: add explanation for the fields in mysql.user #18118

Merged
merged 4 commits into from
Jul 29, 2024
Merged

tidb: add explanation for the fields in mysql.user #18118

merged 4 commits into from
Jul 29, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jul 25, 2024

What is changed, added or deleted? (Required)

  • add explanation for the fields in mysql.user
  • put mysql-schema*.md in a unique dir

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 25, 2024
@Oreoxmt Oreoxmt self-assigned this Jul 25, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 25, 2024

/cc @CbcWestwolf

@ti-chi-bot ti-chi-bot bot requested a review from CbcWestwolf July 25, 2024 06:36
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2024
CbcWestwolf
CbcWestwolf approved these changes Jul 25, 2024
View reviewed changes
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 25, 2024

@CbcWestwolf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt @CbcWestwolf
Apply suggestions from code review
f5bda60 
Co-authored-by: CbcWestwolf <1004626265@qq.com>
@Oreoxmt Oreoxmt requested a review from lilin90 July 26, 2024 02:40
lilin90
lilin90 reviewed Jul 29, 2024
View reviewed changes
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-29 10:16:02.7005059 +0000 UTC m=+178078.980553954: ☑️ agreed by lilin90.

@Oreoxmt @lilin90
Apply suggestions from code review
f732cf3 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@Oreoxmt Oreoxmt added the lgtm label Jul 29, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 29, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 29, 2024
@Oreoxmt Oreoxmt closed this Jul 29, 2024
@Oreoxmt Oreoxmt reopened this Jul 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4cce7b4 into pingcap:master Jul 29, 2024
7 of 10 checks passed
@Oreoxmt Oreoxmt deleted the translate/docs-18318 branch July 29, 2024 10:23
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 29, 2024
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#18118
c45797d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18199.

Oreoxmt added a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 29, 2024
@Oreoxmt
tidb: add explanation for the fields in mysql.user (pingcap#18118)
dde1d7c
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
tidb: add explanation for the fields in mysql.user (#18118) (#18199)
e9213b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-1-more-lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Oreoxmt @ti-chi-bot @CbcWestwolf @lilin90