Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: add explanation for the fields in mysql.user #18318

Merged
merged 15 commits into from
Jul 29, 2024

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Jul 22, 2024

What is changed, added or deleted? (Required)

  • add explanation for the fields in mysql.user
  • put mysql-schema*.md in a unique dir

close #16684

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2024
@Oreoxmt Oreoxmt self-assigned this Jul 22, 2024
@Oreoxmt Oreoxmt added type/enhancement This issue/PR improves documentation usability or supplements document content. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 22, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 22, 2024
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It might be good to put a reminder on this page that these are system tables and that it is not recommended to change them directly. The recommended way is to use CREATE USER/ALTER USER/DROP USER/GRANT/REVOKE/SHOW CREATE USER etc.
  2. When people still want to make changes to these tables directly they should run FLUSH PRIVILEGES.
  3. Do we want/need to put in a statement about what is MySQL compatible and what's not?
  4. Would still be good to have a page per table instead of one page for all tables combined. Just like information_schema descriptions.

mysql-schema.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2024
@CbcWestwolf CbcWestwolf force-pushed the mysql-user branch 2 times, most recently from 06a3e1d to 597aef8 Compare July 22, 2024 06:49
mysql-schema/mysql-schema.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jul 22, 2024

@dveeden: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Daniël van Eeden <github@myname.nl>
TOC-tidb-cloud.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
mysql-schema/mysql-schema-user.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt Oreoxmt self-requested a review July 24, 2024 08:24
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 25, 2024
Copy link

ti-chi-bot bot commented Jul 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-22 06:11:21.607350432 +0000 UTC m=+852703.598291901: ☑️ agreed by dveeden.
  • 2024-07-25 06:37:18.224016212 +0000 UTC m=+1113460.214957681: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt requested a review from lilin90 July 26, 2024 02:40
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 29, 2024

/approve

Copy link

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit bb01d49 into pingcap:master Jul 29, 2024
7 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18417.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
@CbcWestwolf CbcWestwolf deleted the mysql-user branch July 30, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add field explanations for TiDB mysql schema tables
6 participants