-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb: add explanation for the fields in mysql.user
#18318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It might be good to put a reminder on this page that these are system tables and that it is not recommended to change them directly. The recommended way is to use
CREATE USER
/ALTER USER
/DROP USER
/GRANT
/REVOKE
/SHOW CREATE USER
etc. - When people still want to make changes to these tables directly they should run
FLUSH PRIVILEGES
. - Do we want/need to put in a statement about what is MySQL compatible and what's not?
- Would still be good to have a page per table instead of one page for all tables combined. Just like
information_schema
descriptions.
Co-authored-by: Daniël van Eeden <github@myname.nl>
06a3e1d
to
597aef8
Compare
@dveeden: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Daniël van Eeden <github@myname.nl>
Co-authored-by: Aolin <aolinz@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What is changed, added or deleted? (Required)
mysql.user
mysql-schema*.md
in a unique dirclose #16684
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?