Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Fix bug for region_score with store's used_size is zero (#2471) #2474

Merged
merged 3 commits into from
May 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 28, 2020

cherry-pick #2471 to release-4.0


Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Fix #2470

What is changed and how it works?

If store's used size is zero, just set amplification = 1 to avoid divide by zero error.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix bug that can not get store information when store's used size is zero

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@nolouch
Copy link
Contributor

nolouch commented May 29, 2020

/run-all-tests

@nolouch
Copy link
Contributor

nolouch commented May 30, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 30, 2020

/run-all-tests

@sre-bot sre-bot merged commit cf8d3c1 into tikv:release-4.0 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants