schedule: fix panic issue after delete the rule (#2513) #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
lhy1024
approved these changes
Jun 5, 2020
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2515 +/- ##
============================================
Coverage 77.10% 77.10%
============================================
Files 204 204
Lines 21885 21887 +2
============================================
+ Hits 16874 16877 +3
+ Misses 3730 3727 -3
- Partials 1281 1283 +2
Continue to review full report at Codecov.
|
|
/approve |
|
/merge |
nolouch
approved these changes
Jun 5, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2513 to release-4.0
What problem does this PR solve?
Fix #2478
What is changed and how it works?
check the length.
Check List
Tests
Release note